Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup] Kconfig: create duplicate of sign key #129

Closed

Conversation

hakonfam
Copy link
Contributor

This duplicate is needed for the parent image to have access
to the signing key when MCUBoot is not built from source.

Ref: NCSDK-6859
Signed-off-by: Håkon Øye Amundsen haakon.amundsen@nordicsemi.no

@hakonfam
Copy link
Contributor Author

This is needed since I asked @nvlsianpu to remove the duplicate here: #119 (review)

@mbolivar-nordic I was thinking about leveraging the kconfig variable introduced to solve the same issue with west sign but my gut feeling was to revert this change, since its how it used to work before. Any thoughts?

This duplicate is needed for the parent image to have access
to the signing key when MCUBoot is not built from source.

Ref: NCSDK-6859
Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
@mbolivar-nordic
Copy link
Contributor

Any thoughts?

I'm really losing the bubble on what's going on with these; let's talk offline

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to revert all NCS specific patches, like: 04514d6 regarding Kconfig changes, and move all the Kconfig logic (including this PR) into https://github.com/nrfconnect/sdk-nrf

Will be happy to assist on that work if you agree.

@hakonfam
Copy link
Contributor Author

Note to self, verify that the new solution sets the default value in the application.
This can be done building a project with MCUBOOT without setting the key explitcitly.

@hakonfam
Copy link
Contributor Author

Will be fixed using MODULE_ROOT functionality.

@hakonfam hakonfam closed this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants